Enforce newline at end of files #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing newlines are a common idiom in programming, and enabling this rule will save reviewers nitpicking or overlooking missing trailing newlines. ESLint also supports the `--fix` option to automate fixing some of the problems reported by this rule. There are no current files in the codebase that require fixing to add trailing newlines as verified by `npm run lint`.
|
To consider:
If we want to enforce just one trailing newline, we would also need to enable no-multiple-empty-lines to control maxEOF. |
|
I'll let @modeswitch review this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing newlines are a common idiom in programming, and enabling this rule will save reviewers nitpicking or overlooking missing trailing newlines.
ESLint also supports the
--fixoption to automate fixing some of the problems reported by this rule.There are no current files in the codebase that require fixing to add trailing newlines as verified by
npm run lint.